Add setting to only analyze open documents for references #4170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,6 +102,7 @@ export interface ISettings { | |||
| cwd?: string; | |||
| notebooks?: INotebooksSettings; | |||
| enableReferencesCodeLens?: boolean; | |||
| analyzeOpenDocumentsOnly?: boolean; | |||
There was a problem hiding this comment.
btw I picked this name specifically to match C#'s
It doesn't perfectly fit, but I think it's pretty accurate. Open to changing though.
Comment on lines
+277
to
+278
| analyzeOpenDocumentsOnly: | ||
| configuration.get<boolean>("analyzeOpenDocumentsOnly", true), |
There was a problem hiding this comment.
Don't we need a bit in package.json too?
There was a problem hiding this comment.
lol sure do. My b, I'll commit that in a sec. Good catch!
andyleejordan
pushed a commit
to PowerShell/PowerShellEditorServices
that referenced
this pull request
Sep 15, 2022
Significantly reduce performance overhead of reference finding in large workspaces. * Dependent on PowerShell/vscode-powershell#4170 * Adds a reference cache to every ScriptFile * Workspace scan is performed only once on first request * An LSP file system watcher provides updates for files not changed via Did*TextDocument notifications * Adds a setting to only search "open documents" for references. This disables both the initial workspace scan and the file system watcher, relying only on Did*TextDocument notifications. As a stress test I opened up my profile directory (which has ~3k script files in total in the Modules directory) and created a file with a function definition on every line. I then tabbed to a different file, and then tabbed back to the new file. Before the changes, the references code lens took ~10 seconds to populate and my CPU spiked to ~50% usage. After the changes, they populated instantly and CPU spiked to ~2% usage.
andyleejordan
approved these changes
Sep 27, 2022
andyleejordan
added
Issue-Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Dependent on PowerShell/PowerShellEditorServices#1917
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready